add case for virt-xml-validate for virsh domcap #6080
Conversation
Thanks yingshun : D , Updated |
xxxx-17141:validate libvirt XML files against a virsh domcap schema Signed-off-by: nanli <[email protected]>
nanli1
force-pushed
the
add_case_for_virt_xml_validate_the_virsh_domcapabilities
branch
from
718d617 to
8866594
Compare
| @@ -230,6 +241,10 @@ def run(test, params, env): | |||
| secret_validate(test, secret_volume, file=output_path, **virsh_dargs) | |||
| elif schema == "interface": | |||
| interface_validate(test, file=output_path, **virsh_dargs) | |||
| elif schema == "domcapabilities": | |||
| libvirt_version.is_libvirt_feature_supported(params) | |||
There was a problem hiding this comment.
Thank you @nanli1 for adding version check! I'm thinking it'll be better if we could move version checking to the beginning of all tests. In this way, if the existing libvirt version doesn't support a function, it could stop the test as early as possible.
There was a problem hiding this comment.
Thanks yingshun, but other scenarios are not influenced by this libvirt version checking , I could not find a better line to check version
There was a problem hiding this comment.
I usually put it in the first few lines of run(). For other tests, t'll skip the version checking if there's no func_supported_since_libvirt_ver.
Signed-off-by: nanli [email protected]