Filter virtio_transitional_blk on s390x

[chunfuwen]

s390x
In s390x avocado-vt-vm1 guest, there is already one virto-scsi controller, but the code to libvirt.set_vm_disk(vm, params) to update it, but it throw error: XML error: Multiple 'scsi' controllers with index '0'

[chunfuwen]

this is previous error on s390x:
2025-01-20 05:40:06,331 avocado.virttest.libvirt_vm libvirt_vm L2402 WARNI| Requested MAC address release from persistent vm avocado-vt-vm1. Ignoring.
2025-01-20 05:40:06,405 avocado.virttest.virsh virsh L1666 DEBUG| Undefine VM avocado-vt-vm1
2025-01-20 05:40:06,416 avocado.virttest.virsh virsh L1651 DEBUG| Define VM from /var/tmp/xml_utils_temp_q7x19qp5.xml
2025-01-20 05:40:06,431 avocado.test stacktrace L0040 ERROR|
2025-01-20 05:40:06,431 avocado.test stacktrace L0042 ERROR| Reproduced traceback from: /var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/avocado_vt/test.py:298
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| Traceback (most recent call last):
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| File "/var/lib/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-libvirt/libvirt/tests/src/virtio_transitional/virtio_transitional_blk.py", line 261, in run
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| libvirt.set_vm_disk(vm, params)
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| File "/var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/virttest/utils_test/libvirt.py", line 2895, in set_vm_disk
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| add_controller(vm.name, new_added)
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| File "/var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/virttest/utils_test/libvirt.py", line 1592, in add_controller
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| vmxml.sync()
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| File "/var/ci/libvirt-ci/runtest/avocado-vt/avocado-vt/virttest/libvirt_xml/vm_xml.py", line 853, in sync
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| raise xcepts.LibvirtXMLError(
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| virttest.libvirt_xml.xcepts.LibvirtXMLError: Failed to define avocado-vt-vm1 for reason:
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| error: Failed to define domain from /var/tmp/xml_utils_temp_3_c2xdpu.xml
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR| error: XML error: Multiple 'scsi' controllers with index '0'
2025-01-20 05:40:06,437 avocado.test stacktrace L0049 ERROR|
2025-01-20 05:40:06,437 avocado.test stacktrace L0050 ERROR|
2025-01-20 05:40:06,472 avocado.virttest.libvirt_vm libvirt_vm L2402 WARNI| Requested MAC address release from persistent vm avocado-vt-vm1. Ignoring.
2025-01-20 05:40:06,509 avocado.virttest.qemu_storage qemu_storage L1785 DEBUG| Checking image file /var/lib/avocado/data/avocado-vt/images/jeos-27-s390x.qcow2

[chunfuwen]

@smitterl please double check it

[smitterl]

@chunfuwen Thanks for this. In this case - when domain xml assumptions don't hold - we usually remove all elements that are not expected to be on the domain. I'd either do that or disable the whole test suite as it seems to have little value: only virtio is supported on s390x, we have the virtio-scsi controler per default and https://github.com/autotest/tp-libvirt/blob/master/libvirt/tests/cfg/virsh_cmd/domain/virsh_attach_device.cfg#L241 also coveres attach/detach scenario.

What do you think?