-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: VPP CE Integration #116
feat: VPP CE Integration #116
Conversation
Progress vid: https://youtu.be/ZrvKUv_EE1U |
42c5bcb
to
8905075
Compare
Running from editor causes low fps compared to binary build. Driving videos with adjusted vehicle specs that I was able to find from the web.
I've calibrated the pedal maps for the updated vehicle with the accel_brake_map_calibrator Videos with Autoware actuation commands: |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
I didn’t encounter any issues when controlling the vehicle with the keyboard. Compared to the previous version, it offered a more realistic driving experience. Thank you for your work! When I tried driving with Autoware, I encountered a few issues:
|
Signed-off-by: Alptuğ Cırıt <[email protected]>
The issue about "vehicle turning corners" works properly in default |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Here is the side by side comparison: |
While driving the vehicle I can move the vehicle forward even though I haven't enabled keyboard control from the UI. But aside from that, everything else seems to be fixed. |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Description
This PR replaces current vehicle dynamics with Vehicle Physics Pro. This will allow users to observe more realistic vehicle behaviors from the simulation.
You need to add the following scripts to an VPP configured vehicle to be able to drive it with Autoware:
AutowareVPPAdapter.cs
: Used for applying the control inputs to the vehicle.Ros2ToVPPInput.cs
: Used for receiving the control inputs from the Autoware.VPPVehicleSignalHandler.cs
: Used for handling the signals from the vehicle.VPPToRos2Publisher.cs
: Used for publishing the vehicle state to the Autoware.Other new stuff & changes:
Detailed steps for the integration is explained in the docs.
Updated Pedal Maps
Related links
Main Issue
Related Issues/PRs
Tests performed
Tested with Autoware in the editor and the binary build.
Comparison with Main Branch
Test drive from Editor
Test drive from Binary
Effects on system behavior
Low fps when running with Autoware from the editor.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.