Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VPP CE Integration #116

Merged
merged 48 commits into from
Sep 13, 2024

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Jul 12, 2024

Description

This PR replaces current vehicle dynamics with Vehicle Physics Pro. This will allow users to observe more realistic vehicle behaviors from the simulation.

You need to add the following scripts to an VPP configured vehicle to be able to drive it with Autoware:

  • AutowareVPPAdapter.cs: Used for applying the control inputs to the vehicle.
  • Ros2ToVPPInput.cs: Used for receiving the control inputs from the Autoware.
  • VPPVehicleSignalHandler.cs: Used for handling the signals from the vehicle.
  • VPPToRos2Publisher.cs: Used for publishing the vehicle state to the Autoware.

Other new stuff & changes:

  • The vehicle in the launch command has changed. (Details in docs.)
  • Calibrated new pedal maps for the default Lexus vehicle. Please put these files into the raw_vehicle_cmd node. Otherwise pedal percentages are insufficient for vehicle to accelerate properly. (Details in docs.)

Detailed steps for the integration is explained in the docs.

Updated Pedal Maps

Related links

Main Issue

Related Issues/PRs

Tests performed

Tested with Autoware in the editor and the binary build.
Comparison with Main Branch
Test drive from Editor
Test drive from Binary

Effects on system behavior

Low fps when running with Autoware from the editor.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mozhoku mozhoku added the type:new-feature New functionalities or additions, feature requests. label Jul 12, 2024
@mozhoku mozhoku self-assigned this Jul 12, 2024
@mozhoku
Copy link
Collaborator Author

mozhoku commented Jul 19, 2024

Progress vid: https://youtu.be/ZrvKUv_EE1U

@mozhoku mozhoku changed the title (WIP) feat: VPP Integration feat: VPP Integration Jul 24, 2024
@mozhoku mozhoku force-pushed the feat/vpp-ce-integration branch from 42c5bcb to 8905075 Compare July 30, 2024 15:56
@mozhoku
Copy link
Collaborator Author

mozhoku commented Aug 14, 2024

Running from editor causes low fps compared to binary build.

Driving videos with adjusted vehicle specs that I was able to find from the web.

  • Unfortunately I couldn't find any engine torque/power graphs for the Lexus RX450h 2015 online so I tried to create a graph that satisfies available information. This car has electric motors working with the engine. simulation does not take these into consideration. I also did not take this into consideration when adjusting the engine torque/power graph.

  • Only info I had about the combustion engine was MaxPower@RPM and MaxTorque@RPM. This is the graph that satisfies the info at hand, visualized in VPP:
    image

  • As for the gear ratios, the vehicle has CVT. Afaik these don't have set gear ratios and I couldn't find any info regarding to the gear ratios. I left them as they are.

  • I didn't touch the differential settings in the vehicle driveline neither.

I've calibrated the pedal maps for the updated vehicle with the accel_brake_map_calibrator

Videos with Autoware actuation commands:
Test drive from Editor
Test drive from Binary

@mozhoku mozhoku changed the title feat: VPP Integration feat: VPP CE Integration Aug 23, 2024
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku marked this pull request as ready for review September 6, 2024 09:36
@mozhoku mozhoku marked this pull request as draft September 6, 2024 09:39
@mozhoku mozhoku marked this pull request as ready for review September 6, 2024 10:16
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
@Aysenayilmaz
Copy link
Collaborator

I didn’t encounter any issues when controlling the vehicle with the keyboard. Compared to the previous version, it offered a more realistic driving experience. Thank you for your work!

When I tried driving with Autoware, I encountered a few issues:

  • A command had to be added to drive the vehicle with Autoware. The part 'launch_vehicle_interface:=true' wasn't mentioned in the documentation.
  • Changes were needed in the brake_map.csv file values.
  • Before switching to autonomous driving, you need to enable and disable keyboard control.
  • The vehicle couldn’t turn properly in corners. (There was no issue with keyboard driving).

Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku
Copy link
Collaborator Author

mozhoku commented Sep 9, 2024

The issue about "vehicle turning corners" works properly in default AutowareSimulation scene.
It fails to drive when launched from the Loader scene.
I'll look into it.

Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku marked this pull request as draft September 10, 2024 07:46
@mozhoku mozhoku marked this pull request as ready for review September 10, 2024 11:27
@mozhoku
Copy link
Collaborator Author

mozhoku commented Sep 10, 2024

Here is the side by side comparison:

https://youtu.be/oTl1rWWoBQw

@Aysenayilmaz
Copy link
Collaborator

While driving the vehicle I can move the vehicle forward even though I haven't enabled keyboard control from the UI. But aside from that, everything else seems to be fixed.

https://youtu.be/NFdxtvFaGvU

Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku merged commit ac4ff08 into autowarefoundation:main Sep 13, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs type:new-feature New functionalities or additions, feature requests.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants