forked from tier4/AWSIM
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ss2 scene to launch setup #142
Merged
mozhoku
merged 13 commits into
autowarefoundation:main
from
mozhoku:feat/add-ss2-to-launch-setup
Sep 19, 2024
Merged
feat: add ss2 scene to launch setup #142
mozhoku
merged 13 commits into
autowarefoundation:main
from
mozhoku:feat/add-ss2-to-launch-setup
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozhoku
added
the
type:new-feature
New functionalities or additions, feature requests.
label
Sep 13, 2024
mozhoku
changed the title
feat: add ss2 to launch setup
feat: add ss2 scene to launch setup
Sep 13, 2024
Aysenayilmaz
approved these changes
Sep 19, 2024
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
mozhoku
force-pushed
the
feat/add-ss2-to-launch-setup
branch
from
September 19, 2024 10:13
a2ef07a
to
47218f4
Compare
mozhoku
added
type:enchantment
Improve existing feature
and removed
type:new-feature
New functionalities or additions, feature requests.
labels
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of ss2 scene to the current
Loader
scene for ease of usage and distribution.ss2 is used by OpenSCENEARIO.
Build Settings
when opening the project. Saves these to an asset in theResources
folder with a scriptable object namedSceneMetadataUpdater
. And uses it in the runtime for checking whether a scene is used for scenario simulator or not.Can be extended for future use.
Example:
Related links
scenario simulator scene
to the multi scene setup #141Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.