Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ss2 scene to launch setup #142

Merged
merged 13 commits into from
Sep 19, 2024

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Sep 13, 2024

Description

Addition of ss2 scene to the current Loader scene for ease of usage and distribution.
ss2 is used by OpenSCENEARIO.

  • Simulator scenes tracked with a scriptable object. It loads the active scenes in the Build Settings when opening the project. Saves these to an asset in the Resources folder with a scriptable object named SceneMetadataUpdater. And uses it in the runtime for checking whether a scene is used for scenario simulator or not.

Can be extended for future use.

Example:
image

Related links

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mozhoku mozhoku self-assigned this Sep 13, 2024
@mozhoku mozhoku added the type:new-feature New functionalities or additions, feature requests. label Sep 13, 2024
@mozhoku mozhoku changed the title feat: add ss2 to launch setup feat: add ss2 scene to launch setup Sep 13, 2024
@mozhoku mozhoku marked this pull request as ready for review September 16, 2024 14:42
mozhoku and others added 13 commits September 19, 2024 13:09
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku force-pushed the feat/add-ss2-to-launch-setup branch from a2ef07a to 47218f4 Compare September 19, 2024 10:13
@mozhoku mozhoku merged commit d8f800c into autowarefoundation:main Sep 19, 2024
5 of 7 checks passed
@mozhoku mozhoku deleted the feat/add-ss2-to-launch-setup branch September 19, 2024 10:15
@mozhoku mozhoku added type:enchantment Improve existing feature and removed type:new-feature New functionalities or additions, feature requests. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs type:enchantment Improve existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants