Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update lighting and mats #56

Merged
merged 19 commits into from
Apr 24, 2024

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Apr 19, 2024

Description

Updates scene lighting and some materials to make it similar to HDRP version. Adjusted traffic light and vehicle light scripts to work properly with the URP. These changes should fix the traffic light detection problem.

Also updated the Nishishinjuku_URP.unitypackage here. Updated documentation with the new package link.

Enabled auto light baking. Changed default lighting settings for faster light baking. This change is intended to aid users with low-end PCs. However, those with high-end systems retain the flexibility to customize their settings as desired.

Related links

Tests performed

Tested visual changes on Windows and Linux. Didn't tested with Autoware.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mozhoku mozhoku self-assigned this Apr 19, 2024
mozhoku added 2 commits April 19, 2024 18:07
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku marked this pull request as ready for review April 19, 2024 15:53
@mozhoku mozhoku requested a review from xmfcx April 19, 2024 15:53
@mozhoku mozhoku added type:bug Software flaws or errors. tag:deploy-docs labels Apr 19, 2024
Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku requested a review from lchojnack April 19, 2024 16:08
@xmfcx
Copy link

xmfcx commented Apr 19, 2024

Could you share the before and after images?

Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku
Copy link
Collaborator Author

mozhoku commented Apr 19, 2024

HDRP vs Old URP vs New URP
vs

@xmfcx xmfcx changed the title Update/lighting and mats feat: update lighting and mats Apr 19, 2024
@xmfcx
Copy link

xmfcx commented Apr 22, 2024

Did you test this with the Autoware to see the green light performance?

@xmfcx
Copy link

xmfcx commented Apr 22, 2024

URP HDRP
Screenshot from 2024-04-22 16-35-16 Screenshot from 2024-04-22 16-35-20
Has white Only has the color
Has specular surface Has matte or pure emissive surface

Could you fix these?

mozhoku added 2 commits April 22, 2024 17:39
Signed-off-by: Alptuğ Cırıt <[email protected]>
@xmfcx
Copy link

xmfcx commented Apr 22, 2024

Comparison video between AWSIM 1.2.1 with HDRP vs AWSIM Labs with URP

Comparison  Video

@mozhoku
Copy link
Collaborator Author

mozhoku commented Apr 22, 2024

I've updated the Nishishinjuku package and the post process settings. If you are going to test again you need to download the package from here. Greens should be OK now.

image

@mozhoku
Copy link
Collaborator Author

mozhoku commented Apr 24, 2024

Here is the video comparison with the updated environment:
https://youtu.be/7efsNXH0kA0

@xmfcx xmfcx merged commit 50a0f7f into autowarefoundation:main Apr 24, 2024
6 of 7 checks passed
@xmfcx
Copy link

xmfcx commented Apr 24, 2024

Thanks, it works even better with the traffic lights than the original because of the lack of fog I think!

@mozhoku mozhoku deleted the update/lighting-and-mats branch May 2, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants