-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update lighting and mats #56
feat: update lighting and mats #56
Conversation
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
Documentation URL: https://autowarefoundation.github.io/AWSIM/pr-56/ |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Could you share the before and after images? |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Did you test this with the Autoware to see the green light performance? |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
I've updated the Nishishinjuku package and the post process settings. If you are going to test again you need to download the package from here. Greens should be OK now. |
Here is the video comparison with the updated environment: |
Signed-off-by: Alptuğ Cırıt <[email protected]>
Thanks, it works even better with the traffic lights than the original because of the lack of fog I think! |
Description
Updates scene lighting and some materials to make it similar to HDRP version. Adjusted traffic light and vehicle light scripts to work properly with the URP. These changes should fix the traffic light detection problem.
Also updated the Nishishinjuku_URP.unitypackage here. Updated documentation with the new package link.
Enabled auto light baking. Changed default lighting settings for faster light baking. This change is intended to aid users with low-end PCs. However, those with high-end systems retain the flexibility to customize their settings as desired.
Related links
Tests performed
Tested visual changes on Windows and Linux. Didn't tested with Autoware.
Effects on system behavior
Not applicable.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.