Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sync-files): escape double quotes to avoid pre-commit modifying the file #117

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Dec 10, 2024

Description

Because it was adding it with single quotes, pre-commit replaces it with double quotes. And this way it creates a useless PR.

sync-files commit
image

pre-commit auto-fix commit
image

end result:
image

Related links

Follow up from:

How was this PR tested?

The pr was self-closed by the sync-files action ✅

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 10, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx requested a review from youtalk December 10, 2024 13:42
@xmfcx xmfcx self-assigned this Dec 10, 2024
@xmfcx xmfcx marked this pull request as ready for review December 10, 2024 13:42
@xmfcx xmfcx enabled auto-merge (squash) December 10, 2024 13:44
@xmfcx xmfcx requested a review from mitsudome-r December 10, 2024 14:07
@xmfcx xmfcx merged commit 4f09f58 into autowarefoundation:main Dec 10, 2024
36 checks passed
@xmfcx xmfcx deleted the ci/fix-sync-files-quotes branch December 10, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants