Skip to content

Commit

Permalink
refactor(docker): minimize hadolint ignore (#5102)
Browse files Browse the repository at this point in the history
* minimize hadolint ignore

Signed-off-by: Yutaka Kondo <[email protected]>

* fix sc2002

Signed-off-by: Yutaka Kondo <[email protected]>

* revert sc2002

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
  • Loading branch information
youtalk authored Aug 19, 2024
1 parent 6ce1211 commit ee6d910
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# hadolint global ignore=DL3006,DL3008,DL3013
ARG BASE_IMAGE

# hadolint ignore=DL3006
FROM $BASE_IMAGE AS base
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
ARG ROS_DISTRO
Expand Down Expand Up @@ -32,6 +32,7 @@ RUN --mount=type=ssh \
# Create entrypoint
CMD ["/bin/bash"]

# hadolint ignore=DL3006
FROM $BASE_IMAGE AS rosdep-depend
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
ARG ROS_DISTRO
Expand Down Expand Up @@ -84,7 +85,6 @@ ARG ROS_DISTRO
ARG SETUP_ARGS
ENV CCACHE_DIR="/root/.ccache"

# cspell: ignore libcu libnv
# Set up development environment
RUN --mount=type=ssh \
--mount=type=cache,target=/var/cache/apt,sharing=locked \
Expand Down

0 comments on commit ee6d910

Please sign in to comment.