Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The versions of sample_sensor_kit_launch and awsim_labs_sensor_kit_launch has to be fixed #5544

Open
3 tasks done
mitsudome-r opened this issue Dec 9, 2024 · 3 comments
Open
3 tasks done

Comments

@mitsudome-r
Copy link
Member

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Current main branch fails launch with sample_sensor_kit_launch and awsim_labs_sensor_kit_launch because the versions in autoware.repos is not fixed whereas autoware.universe is fixed in autoware.repos file. This causes some incompatibility when there is a package name change.

Expected behavior

The versions for sample_sensor_kit_launch and awsim_labs_sensor_kit_launch are fixed in autoware.repos file.

Actual behavior

The main branch is used for sample_sensor_kit_launch and awsim_labs_sensor_kit_launch.

Steps to reproduce

  1. git clone https://github.com/autowarefoundation/autoware
  2. mkdir src
  3. vcs import src < autoware.repos
  4. rosdep install --from-paths src --ignore-src --rosdistro $ROS_DISTRO

Then you get the following error:

awsim_sensor_kit_launch: Cannot locate rosdep definition for [autoware_vehicle_velocity_converter]
sample_sensor_kit_launch: Cannot locate rosdep definition for [autoware_vehicle_velocity_converter]

Versions

No response

Possible causes

No response

Additional context

No response

@mitsudome-r
Copy link
Member Author

I will create a tag for the respective repositories that is compatible with version 0.39.0 of autoware.universe and update autoware.repos.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 12, 2024

https://github.com/autowarefoundation/autoware/releases/tag/0.39.1 was created at the respective commit.

@mitsudome-r
Copy link
Member Author

We should also fix the other sensor_kits repository version.
I will create the PRs for those packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants