Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_map_msgs): add MapProjectorInfo message #102

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Oct 31, 2024

Description

This ports the MapProjectorInfo message from tier4_autoware_map_msgs to autoware_map_msgs.
This message is already defined as a interface in Autoware Design Document for Map module and should be added as Autoware's core interface.

I would like to merge them before I port map_loader packages into Autoware Core from Universe.

Related links

Tests performed

I have tested that it build properly on my local machine

Notes for reviewers

none

Interface changes

Addes new message: MapProjectorInfo message

Effects on system behavior

No effects until the packages that use tier4_autoware_msgs/MapProjectorInfo is replaced.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r mitsudome-r requested a review from xmfcx October 31, 2024 06:21
autoware_map_msgs/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit c246607 into autowarefoundation:main Oct 31, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants