feat(autoware_planning_msgs): add messages for the mapless_architecture #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-eisenmann-driveblocks
changed the title
simon-eisenmann-driveblocks
changed the title
Signed-off-by: Simon Eisenmann <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
simon-eisenmann-driveblocks
force-pushed
the
main
branch
from
ce7e3ad to
55ad133
Compare
simon-eisenmann-driveblocks
changed the title
Signed-off-by: Simon Eisenmann <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
maxime-clem
reviewed
Jul 2, 2024
Comment on lines
5
to
6
| int32[] successor_lanelet_id | ||
| int32[] neighboring_lanelet_id |
There was a problem hiding this comment.
we should avoid using the term "lanelet" (also remove from the comment on line 1 and in RoadSegments (line 2).
Suggested change
| int32[] successor_lanelet_id | |
| int32[] neighboring_lanelet_id | |
| int32[] successor_segment_id | |
| int32[] neighboring_segment_id |
Signed-off-by: Simon Eisenmann <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
|
PR will be done here: tier4/mapless_autoware#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added new messages required for the mapless architecture.
Related links
Related GitHub discussion: https://github.com/orgs/autowarefoundation/discussions/4545
Tests performed
This PR was tested using rosbags.
Notes for reviewers
Related PR in the autoware.universe repository: autowarefoundation/autoware.universe#7709
Interface changes
No interfaces are changed. We just added some new messages.
Effects on system behavior
The system behavior is not affected.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.