feat(perception_reproducer): add publish route option #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyoichi Sugahara <[email protected]>
…functions Signed-off-by: Kyoichi Sugahara <[email protected]>
…lity Signed-off-by: Kyoichi Sugahara <[email protected]>
…oses from rosbag Signed-off-by: Kyoichi Sugahara <[email protected]>
…ose and goal pose retrieved from the beginning and end of the rosbag Signed-off-by: Kyoichi Sugahara <[email protected]>
kyoichi-sugahara
requested review from
taikitanaka3,
TakaHoribe,
takayuki5168 and
0x126
as code owners
Signed-off-by: Kyoichi Sugahara <[email protected]>
kosuke55
approved these changes
Nov 19, 2024
kyoichi-sugahara
deleted the
feat/perception_reproducer/add_route_option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the pub-route option to perception_reproducer, enabling route generation using the first and last poses contained in the rosbag.
Previously, perception_reproducer execution and initial/goal pose setting had to be performed separately, but with this added functionality, that work is no longer necessary.
Related links
Tests performed
I have confirmed that routes are being generated successfully.
2024-11-19_09.49.10.mp4
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.