Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: pointcloud_preprocessor prefix package and namespace with autoware #3

Merged
merged 2 commits into from
Jul 22, 2024
Merged

refactor!: pointcloud_preprocessor prefix package and namespace with autoware #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2389798
refactor!: pointcloud_preprocessor prefix package and namespace with …
amadeuszsz Jul 11, 2024
8b6dc3f
style: depends order
amadeuszsz Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions awsim_labs_sensor_kit_launch/launch/pointcloud_preprocessor.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ def launch_setup(context, *args, **kwargs):

# set concat filter as a component
concat_component = ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent",
package="autoware_pointcloud_preprocessor",
plugin="autoware::pointcloud_preprocessor::PointCloudConcatenateDataSynchronizerComponent",
name="concatenate_data",
remappings=[
("~/input/twist", "/sensing/vehicle_velocity_converter/twist_with_covariance"),
Expand Down
2 changes: 1 addition & 1 deletion awsim_labs_sensor_kit_launch/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

<buildtool_depend>ament_cmake_auto</buildtool_depend>

<exec_depend>autoware_pointcloud_preprocessor</exec_depend>
<exec_depend>common_sensor_launch</exec_depend>
<exec_depend>gnss_poser</exec_depend>
<exec_depend>pointcloud_preprocessor</exec_depend>
<exec_depend>tamagawa_imu_driver</exec_depend>
<exec_depend>topic_tools</exec_depend>
<exec_depend>ublox_gps</exec_depend>
Expand Down
16 changes: 8 additions & 8 deletions common_awsim_labs_sensor_launch/launch/velodyne_node_container.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ def create_parameter_dict(*args):

nodes.append(
ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::CropBoxFilterComponent",
package="autoware_pointcloud_preprocessor",
plugin="autoware::pointcloud_preprocessor::CropBoxFilterComponent",
name="crop_box_filter_self",
remappings=[
("input", "pointcloud_raw_ex"),
Expand All @@ -94,8 +94,8 @@ def create_parameter_dict(*args):

nodes.append(
ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::CropBoxFilterComponent",
package="autoware_pointcloud_preprocessor",
plugin="autoware::pointcloud_preprocessor::CropBoxFilterComponent",
name="crop_box_filter_mirror",
remappings=[
("input", "self_cropped/pointcloud_ex"),
Expand All @@ -108,8 +108,8 @@ def create_parameter_dict(*args):

nodes.append(
ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::RingOutlierFilterComponent",
package="autoware_pointcloud_preprocessor",
plugin="autoware::pointcloud_preprocessor::RingOutlierFilterComponent",
name="ring_outlier_filter",
remappings=[
("input", "rectified/pointcloud_ex"),
Expand All @@ -130,8 +130,8 @@ def create_parameter_dict(*args):
)

distortion_component = ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::DistortionCorrectorComponent",
package="autoware_pointcloud_preprocessor",
plugin="autoware::pointcloud_preprocessor::DistortionCorrectorComponent",
name="distortion_corrector_node",
remappings=[
("~/input/twist", "/sensing/vehicle_velocity_converter/twist_with_covariance"),
Expand Down