Skip to content

Commit

Permalink
Don't throw an error on empty attribute group selection
Browse files Browse the repository at this point in the history
  • Loading branch information
jonlamb-gh committed Nov 28, 2023
1 parent 88ca650 commit 27f0739
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions vscode/src/timelines.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,11 @@ export class TimelinesTreeDataProvider implements vscode.TreeDataProvider<Timeli
});

const pickedItems = await vscode.window.showQuickPick(pickItems, { canPickMany: true });
this.workspaceState.setGroupingAttrKeys(pickedItems.map((pi) => pi.label).sort());
this.refresh();
if(pickedItems) {
// User actually selected some attributes to use
this.workspaceState.setGroupingAttrKeys(pickedItems.map((pi) => pi.label).sort());
this.refresh();
}
}

groupTimelinesByNameComponents() {
Expand Down

0 comments on commit 27f0739

Please sign in to comment.