coverage ui #10
Merged
coverage ui #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mullr
commented
Nov 28, 2023
mullr
commented
- Add hooks for spec coverage display
- Consistently use Headline Case for Menu Items
- API rev and some manual HTML templating
- Flesh out spec UI a bit
- Remove spurious '.rs' file
- Update folder metadata on folder/file changes
- Show/hide spec versions, results
- Add batch-eval support to conform spec command
- Further polish on specs panel
- Fix batch eval
- Add some more multi-select commands
- Disable unimplemented menu commands
- Flesh out spec coverage UI
- Use api to update spec icon
jonlamb-gh
requested changes
Nov 28, 2023
vscode/src/specs.ts
Outdated
| if (workspaceState.getShowResults()) { | ||
| super.iconPath = new vscode.ThemeIcon("file", new vscode.ThemeColor("symbolIcon.constructorForeground")); | ||
| } else { | ||
| // TODO color this based on if it has been executed, and if it was successful or not |
There was a problem hiding this comment.
I added some top-level-stats-icon handling for this on the spec-status branch. I can follow up with that once this lands if it's easier.
https://github.com/auxoncorp/speqtr-support/tree/spec-status
There was a problem hiding this comment.
oh man I missed that branch somehow, I'm sorry. I'll pull it in here.
There was a problem hiding this comment.
okay, rebased those commits on here.
jonlamb-gh
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.