Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Deviant mutator/mutations suppport #17

Merged
merged 12 commits into from
Jan 24, 2024
Merged

Conversation

jonlamb-gh
Copy link
Contributor

Experiment-related to follow.

@jonlamb-gh jonlamb-gh requested a review from mullr January 16, 2024 16:25
Copy link
Collaborator

@mullr mullr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some top level notes:

  • Our settings section is still labelled "Auxon SpeQTr", we should probably change that to... something.
  • The view containers should probably be named "Auxon Modality", etc, so it's clear in the the right-click menu where they came from.
  • Can we make the workspaces and segments views at least accessible from the conform and modality tabs? For conform, at least, they should probably be visible by default. Maybe for deviant too, not sure.

},
{
"command": "auxon.deviant.clearMutation",
"title": "Clear mutations using the deviant CLI"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to say 'using the deviant CLI' here. Or.... if we do, then we should be saying it a LOT of other places as well, for consistency.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I've been trying to use headline case for all our menu items. It's not completely consistent though.

},
{
"command": "auxon.deviant.createMutation",
"title": "Create a mutation using the deviant CLI"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@mullr
Copy link
Collaborator

mullr commented Jan 16, 2024

I can create a mutation easily enough, and it shows up. When I clear it though, it never seems to go away.

@mullr
Copy link
Collaborator

mullr commented Jan 16, 2024

The mutations panel should refresh after creating a new mutation

@mullr
Copy link
Collaborator

mullr commented Jan 16, 2024

We should probably enable 'group by mutator name' by default. But even with that turned on, it's kind of a problem:
image
We need some other way to make this list useful. Maybe we can do something similar to the timeline grouping, where the user can choose org metadata values as a grouping axis?

@jonlamb-gh jonlamb-gh merged commit 1164142 into main Jan 24, 2024
1 check passed
@jonlamb-gh jonlamb-gh deleted the deviant-support branch January 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants