Add details panel for graph selection info #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullr
reviewed
Feb 8, 2024
| @@ -320,6 +320,34 @@ | |||
| break; | |||
| } | |||
| }); | |||
| cy.on("cxttap", function (evt) { | |||
mullr
reviewed
Feb 8, 2024
vscode/src/detailsPanel.ts
Outdated
|
|
||
| const templateUri = vscode.Uri.joinPath(this.extensionUri, "templates", "detailsPanel.html"); | ||
| const templateText = fs.readFileSync(templateUri.fsPath, "utf8"); | ||
| const template = handlebars.compile(templateText); |
There was a problem hiding this comment.
We should probably load/compile the template in a less granular scope, like maybe the panel constructor.
mullr
reviewed
Feb 8, 2024
| } | ||
|
|
||
| function constructEvents(events) { | ||
| eventsHeader.innerHTML = "Events"; |
There was a problem hiding this comment.
Since the whole element is being hidden, we can probably put the content for these headers in the template itself, and not worry about having to set innerHTML
There was a problem hiding this comment.
I tried this, but they still show up on initialization when the panel loads. Not sure why, but I assume it's something to do with the flex box display/styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #21