Add events tree view with menus for jupyter notebook generation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonlamb-gh
commented
Nov 1, 2023
jonlamb-gh
commented
- Adds a new tree view for events and their attributes for a selected timeline (currently just a single timeline)
- Adds menus for generating an event-timing jupyter notebook for a selected event and an event attribute notebook for a selected attribute for an event
- Updates the OpenAPI schema to include the newly added events-summary-for-a-timeline
mullr
reviewed
Nov 6, 2023
vscode/src/events.ts
Outdated
| } | ||
|
|
||
| async createEventTimingNotebook(item: EventNameTreeItemData) { | ||
| let selectedEventNames = this.view.selection.flatMap((data) => data.eventName); |
There was a problem hiding this comment.
flatMap seems odd here. Is eventName sometimes an array?
There was a problem hiding this comment.
Nope, I meant to use map here.
mullr
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.