Merkle-ize X-Chain State #3732
Draft
Merkle-ize X-Chain State #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Feb 20, 2025
Comment on lines
+62
to
+68
|
|
||
| // Metadata DB Prefixes | ||
| dbPrefixMetadata = []byte{0x0} | ||
| dbPrefixIndexer = []byte{0x1} | ||
|
|
||
| // State DB Prefixes | ||
| dbPrefixState = []byte{0x1} |
There was a problem hiding this comment.
I was thinking we'd have two prefixes, one for state and one for non-state. As an alternative, we could just have each db live under their own prefix under the root db instead of sharing a common metadata prefix. I don't see a reason to do/not do one over the other so open to suggestions here
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
Need to be documented in RELEASES.md?