Single source of truth for go version #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/diff-go-mod-sum
branch
from
1ced3c9
to
5befa88
Compare
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
geoff-vball
commented
Nov 16, 2023
| @@ -40,9 +42,6 @@ jobs: | |||
| cd subnet-evm | |||
| ./scripts/build.sh /tmp/e2e-test/avalanchego/plugins/srEXiWaHuhNyGwPUi444Tu47ZEDwxTWrbQiuD7FmgSAQ6X7Dy | |||
|
|
|||
| - name: Checkout teleporter repository | |||
There was a problem hiding this comment.
This is already done above on line 23
geoff-vball
commented
Nov 17, 2023
feuGeneA
suggested changes
Nov 17, 2023
Co-authored-by: F. Eugene Aumson <[email protected]> Signed-off-by: Geoff Stuart <[email protected]>
…ter into gstuart/diff-go-mod-sum
geoff-vball
commented
Nov 17, 2023
cam-schultz
reviewed
Nov 17, 2023
cam-schultz
reviewed
Nov 21, 2023
geoff-vball
requested review from
michaelkaplan13,
cam-schultz and
minghinmatthewlam
There was a problem hiding this comment.
I don't love the pattern of using a value set within a comment throughout the code base. At the least, lets add a clear explanation to the comment regarding how it must be formatted and how it's used, but I think I would be in favor of just setting the full version explicitly in versions.sh and having a comment there and in the go.mod that it should be updated in both places when needed.
That's similar to how AvalancheGo approaches it here: https://github.com/ava-labs/avalanchego/blob/master/go.mod#L3
feuGeneA
previously approved these changes
Nov 22, 2023
cam-schultz
reviewed
Nov 22, 2023
cam-schultz
reviewed
Nov 22, 2023
cam-schultz
previously approved these changes
Nov 22, 2023
cam-schultz
approved these changes
Nov 22, 2023
feuGeneA
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Makes the go.mod file the single source of truth for the go version.
Adds a github action to check the go.mod file for any changes after a
go mod tidyAlso augments
versions.shto get the versions fromgo.modso we have a single source of truth for those too!How this works
go.modonly allowsmajor.minorversion, so I've added a comment with the patch version that we will extract withsedin order to install the correct golang version in docker and CI.How this was tested
How is this documented