Fixing solhint lint workflow #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 30, 2023 04:25
minghinmatthewlam
requested review from
michaelkaplan13,
cam-schultz,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
cam-schultz
approved these changes
Sep 1, 2023
gwen917
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes #11 , where workflows should now fail on solhint errors
Adds a solhint disable for a false positive solhint error on
abi.encodeHow this works
solhint **/*.solis apparently different fromsolhint '**/*'.solwhere the latter will sol files in nested directories undercontracts/src, whereas the former only looks at sol files incontracts/srcdirectory and one directory down.How this was tested
ci
How is this documented
added comment in worfklow