Fix Immediate Error Message Display on Form Load #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryabulusu
reviewed
Oct 25, 2024
There was a problem hiding this comment.
looks great! there are CI errors. Can you fix? @Praneeth-2602 I'll merge then. Also change the name of the PR from "Solved the issue" to something meaningful
This was referenced Oct 25, 2024
|
@suryabulusu sure will!! |
Praneeth-2602
changed the title
|
@suryabulusu Done sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #38
Problem: The error message, "Please fill all the fields before submitting!" appeared on page load, instead of after the user tried to submit the form.
Solution:
Removed logic that disabled the submit button, allowing form submission anytime.
Added a formSubmitted state to track if the user attempted submission.
Updated error display logic to show messages only after submission, and only if fields are incomplete.
Form submission is blocked if fields are missing, and the error message is shown.
Key Changes:
Error messages only appear after attempted submission.
Submit button is always enabled.