Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting for removing language popup for org plios #647

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

deepansh96
Copy link
Member

@deepansh96 deepansh96 commented Mar 19, 2024

Fixes #{issue id}

Summary

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
    • Safari (use BrowserStack)
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable:
      • update docs/ENV.md
      • update Github Workflow files
      • update DockerFile
      • update the secrets for staging and production
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVGs without text have their aria-label attributes set

@deepansh96 deepansh96 changed the title removed the locale popup for TAP, will convert it into a setting late… Added setting for removing language popup for org plios Apr 29, 2024
@deepansh96 deepansh96 merged commit 2e72b82 into master Apr 29, 2024
2 of 4 checks passed
@deepansh96 deepansh96 deleted the locale_popup_disable_for_tap branch April 29, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant