avoid frags caused by dead player aborting #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a player aborted a game after their last life their client would send an asynchronous message letting other players knowing they are out. But this could sometimes result in a race condition where other players wouldn't be able to handle the abort keystroke which allows it to clean up and set the `isOut` flag. The result of this was that the aborted player would be counted by some players and not others which messed up the fragmentation checksum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a player aborted a game after their last life their client would send an asynchronous message letting other players knowing they are out. But this could sometimes result in a race condition where other players wouldn't be able to handle the abort keystroke which allows it to clean up and set the
isOutflag. The result of this was that the aborted player would be counted by some players and not others which messed up the fragmentation checksum.