Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade IceCube to 0.11.2 #17

Closed
wants to merge 41 commits into from
Closed

Upgrade IceCube to 0.11.2 #17

wants to merge 41 commits into from

Conversation

dgilperez
Copy link

No description provided.

@avit
Copy link
Owner

avit commented Jan 29, 2014

Hi, thanks for the PR, it's nice to see that someone is using this, but I have a couple of questions about it:

  1. I'm not sure what's happening with the "weird syntax error" you're seeing: I'm not seeing any error there.
  2. The version dependency on IceCube in the gemspec is just a minimum version number. This shouldn't stop you from using a newer version if you just bundle update ice_cube in your app.

@dgilperez
Copy link
Author

Hey!

Yeah, we're using schedule_attributes in production, not with a few glitches so to say. Anyway, it does the job for us ;)

  1. This was like one year ago, I don't remember how to reproduce the error. It may be related to a particular Ruby version, if I recall correctly. It hurt at the time and it was our motivation for the fork. As long as it is a minor change, I hope you don't mind if we keep it our version, so we don't find the bug back again by surprise.
  2. Reverted.

I rebased everything in one single commit.

@dgilperez
Copy link
Author

Hmm I didn't want to add the last commit to this pull request, but another one to solve #18 ...

…f no validation applies, will alter Schedule::Rule, initializing @validations[:month_of_year] with an empty array. Both IceCube and schedule_attributes will benefit for some refactoring of these areas, but this fixes this for now
@avit
Copy link
Owner

avit commented Jan 30, 2014

Sure, I'll take a look and merge it or else just cherry-pick what we need.

@dgilperez
Copy link
Author

Hey @avit, just pinging here to let you know my fork seems to work properly under Rails 4.1, with the last couple of commits. I also upgraded ice_cube to 0.12. I did not test it throughly yet, but it's looking good for the moment.

@avit
Copy link
Owner

avit commented Sep 15, 2014

Cheers, I'll have a look. Currently only using this on a rails-3.2 project myself, but we definitely should update it to work for all the current versions.

Upgrade IceCube & Rails4 compatibility
@dgilperez
Copy link
Author

Hey @avit, any chance that this get merged anytime soon? Thanks and regards!

@dgilperez dgilperez closed this Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants