-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade IceCube to 0.11.2 #17
Conversation
Hi, thanks for the PR, it's nice to see that someone is using this, but I have a couple of questions about it:
|
Hey! Yeah, we're using schedule_attributes in production, not with a few glitches so to say. Anyway, it does the job for us ;)
I rebased everything in one single commit. |
Hmm I didn't want to add the last commit to this pull request, but another one to solve #18 ... |
…f no validation applies, will alter Schedule::Rule, initializing @validations[:month_of_year] with an empty array. Both IceCube and schedule_attributes will benefit for some refactoring of these areas, but this fixes this for now
Sure, I'll take a look and merge it or else just cherry-pick what we need. |
Hey @avit, just pinging here to let you know my fork seems to work properly under Rails 4.1, with the last couple of commits. I also upgraded |
Cheers, I'll have a look. Currently only using this on a rails-3.2 project myself, but we definitely should update it to work for all the current versions. |
Upgrade IceCube & Rails4 compatibility
Hey @avit, any chance that this get merged anytime soon? Thanks and regards! |
…nt fail with "undefined method to_hash for nil:NilClass" for those cases
…l tests green even rails-edge
Rename gem, test with Travis in several Rails versions
…ion warnings from ice_cube
…d_date attributes and merge them into :start_time and :end_time respective ones; keep start_date / start_time attributes in the Input class as it is, for backwards compatibility
…handle failing combinations of dates, start/end_date and start/end_time that popped up
No description provided.