Skip to content

Commit

Permalink
Fix regression where global outputs were unresolveable in DAGs (argop…
Browse files Browse the repository at this point in the history
  • Loading branch information
sarabala1979 authored and jessesuen committed Oct 4, 2019
1 parent cbf9968 commit bb57913
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions workflow/validate/validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,8 @@ func (ctx *templateValidationCtx) validateDAG(scope map[string]interface{}, tmpl
// Verify dependencies for all tasks can be resolved as well as template names
for _, task := range tmpl.DAG.Tasks {
resolvedTmpl, err := ctx.validateTemplateHolder(&task, tmplCtx, &FakeArguments{}, map[string]interface{}{})
prefix := fmt.Sprintf("tasks.%s", task.Name)
ctx.addOutputsToScope(resolvedTmpl, prefix, scope, false)
if err != nil {
return errors.Errorf(errors.CodeBadRequest, "templates.%s.tasks.%s %s", tmpl.Name, task.Name, err.Error())
}
Expand Down

0 comments on commit bb57913

Please sign in to comment.