-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SimpleMDE with EasyMDE #1729
Conversation
Code Climate has analyzed commit 8afb43a and detected 0 issues on this pull request. View more on Code Climate. |
Is this ready to get merged @fastjames, or do you plan on adding more things? |
I started this because I saw it in the |
SimpleMDE has been abandoned for >6 years and is the subject of an npm security advisory. Replace the outdated library with a EasyMDE, which is a maintained fork of SimpleMDE.
74492c1
to
8afb43a
Compare
@adrianthedev I tried this locally and it rendered the in-place editor on the resource create/edit page and on the resource show page as expected. |
In concert with avo-hq/avo#1729, update the documentation to refer to the new editor for Markdown fields.
I have opened avo-hq/docs.avohq.io#54 to update the docs for this PR. |
Thank you @fastjames! |
In concert with avo-hq/avo#1729, update the documentation to refer to the new editor for Markdown fields.
Description
SimpleMDE has been abandoned for >6 years and is the subject of an npm security advisory. Replace the outdated library with a EasyMDE, which is a maintained fork of SimpleMDE.
Added dependencies:
Removed dependencies:
Checklist:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.