Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SimpleMDE with EasyMDE #1729

Merged
merged 1 commit into from
May 17, 2023

Conversation

fastjames
Copy link
Contributor

@fastjames fastjames commented May 8, 2023

Description

SimpleMDE has been abandoned for >6 years and is the subject of an npm security advisory. Replace the outdated library with a EasyMDE, which is a maintained fork of SimpleMDE.

Added dependencies:

Removed dependencies:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate
Copy link

codeclimate bot commented May 8, 2023

Code Climate has analyzed commit 8afb43a and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

Is this ready to get merged @fastjames, or do you plan on adding more things?

@fastjames
Copy link
Contributor Author

Is this ready to get merged @fastjames, or do you plan on adding more things?

I started this because I saw it in the yarn audit output, but I have not tested it very much so that's why it is still in draft.

SimpleMDE has been abandoned for >6 years and is the subject of an npm
security advisory. Replace the outdated library with a EasyMDE, which is
a maintained fork of SimpleMDE.
@fastjames fastjames force-pushed the simplemde_to_easymde branch from 74492c1 to 8afb43a Compare May 16, 2023 14:23
@fastjames fastjames marked this pull request as ready for review May 16, 2023 14:36
@fastjames
Copy link
Contributor Author

@adrianthedev I tried this locally and it rendered the in-place editor on the resource create/edit page and on the resource show page as expected.

fastjames added a commit to fastjames/avodocs that referenced this pull request May 17, 2023
In concert with avo-hq/avo#1729,
update the documentation to refer to the new editor for
Markdown fields.
@fastjames
Copy link
Contributor Author

I have opened avo-hq/docs.avohq.io#54 to update the docs for this PR.

@adrianthedev adrianthedev merged commit c6a51b4 into avo-hq:main May 17, 2023
@adrianthedev
Copy link
Collaborator

Thank you @fastjames!

@fastjames fastjames deleted the simplemde_to_easymde branch May 17, 2023 15:24
Minato116 pushed a commit to Minato116/avodocs that referenced this pull request Feb 24, 2025
In concert with avo-hq/avo#1729,
update the documentation to refer to the new editor for
Markdown fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants