Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avo resource meta #3466

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Avo resource meta #3466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b58bc59
Add .ruby-version file
julianrubisch Apr 24, 2024
26ad6cd
Merge branch 'main' of github.com:minthesize/avo
julianrubisch Jun 17, 2024
3bb6d87
Merge branch 'main' of github.com:minthesize/avo
julianrubisch Oct 30, 2024
bbf4bd4
Merge branch 'avo-hq:main' into main
julianrubisch Nov 26, 2024
ba830e3
chore: Set up Avo Meta
julianrubisch Nov 26, 2024
a63b966
test: Write system test for happy path of creating a new schema entry
julianrubisch Nov 26, 2024
9f8e33c
chore: Extract Avo::Mappings module with constants
julianrubisch Nov 27, 2024
4eddbe3
chore: Reflect changes from avo-meta (look up field type)
julianrubisch Nov 27, 2024
afe545a
chore: Test meta default values
julianrubisch Nov 27, 2024
01cc79a
chore: Test backfilling meta default values
julianrubisch Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,4 @@ brakeman_results.html

.env
.env.test
*~
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,7 @@ gem "avo-record_link_field"
gem "pagy", "> 8"

gem "csv"

gem "avo-meta", github: "avo-hq/avo-meta", branch: "main"

gem "store_model"
54 changes: 33 additions & 21 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ GIT
acts-as-taggable-on (10.0.0)
activerecord (>= 6.1, < 8)

GIT
remote: https://github.com/avo-hq/avo-meta.git
revision: eebe10c85a961a938493282a4330343abd70441c
branch: main
specs:
avo-meta (0.1.0)
avo (~> 3)
store_model (~> 4.1)

GIT
remote: https://github.com/rails/rails.git
revision: b88d9af34fbc1c84ce2769ba02584eab2c28ac6e
Expand Down Expand Up @@ -180,7 +189,7 @@ GEM
backport (1.2.0)
base64 (0.2.0)
bcrypt (3.1.20)
benchmark (0.3.0)
benchmark (0.4.0)
benchmark-ips (2.14.0)
better_html (2.1.1)
actionview (>= 6.0)
Expand Down Expand Up @@ -369,7 +378,7 @@ GEM
activesupport (>= 3.0)
nokogiri (>= 1.6)
io-console (0.7.2)
irb (1.14.0)
irb (1.14.1)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
iso (0.4.0)
Expand All @@ -392,7 +401,7 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
logger (1.6.1)
loofah (2.22.0)
loofah (2.23.1)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
mail (2.8.1)
Expand All @@ -410,8 +419,8 @@ GEM
mini_histogram (0.3.1)
mini_magick (4.13.2)
mini_mime (1.1.5)
mini_portile2 (2.8.7)
minitest (5.25.1)
mini_portile2 (2.8.8)
minitest (5.25.2)
monetize (1.13.0)
money (~> 6.12)
money (6.19.0)
Expand All @@ -438,7 +447,7 @@ GEM
nokogiri (1.16.7-x86_64-linux)
racc (~> 1.4)
orm_adapter (0.5.0)
pagy (9.0.9)
pagy (9.3.1)
parallel (1.26.3)
parser (3.3.5.0)
ast (~> 2.4.1)
Expand All @@ -451,20 +460,19 @@ GEM
prettier_print (1.2.1)
prop_initializer (0.2.0)
zeitwerk (>= 2.6.18)
psych (5.1.2)
psych (5.2.0)
stringio
public_suffix (6.0.1)
puma (6.4.3)
nio4r (~> 2.0)
racc (1.8.1)
rack (3.1.7)
rack (3.1.8)
rack-session (2.0.0)
rack (>= 3.0.0)
rack-test (2.1.0)
rack (>= 1.3)
rackup (2.1.0)
rackup (2.2.1)
rack (>= 3)
webrick (~> 1.8)
rails-controller-testing (1.0.5)
actionpack (>= 5.0.1.rc1)
actionview (>= 5.0.1.rc1)
Expand All @@ -489,7 +497,7 @@ GEM
rb-inotify (0.11.1)
ffi (~> 1.0)
rbs (2.8.4)
rdoc (6.7.0)
rdoc (6.8.1)
psych (>= 4.0.0)
redis (5.3.0)
redis-client (>= 0.22.0)
Expand All @@ -501,7 +509,7 @@ GEM
rainbow (>= 2.0, < 4.0)
rexml (~> 3.1)
regexp_parser (2.9.2)
reline (0.5.10)
reline (0.5.11)
io-console (~> 0.5)
responders (3.1.1)
actionpack (>= 5.2)
Expand Down Expand Up @@ -567,7 +575,7 @@ GEM
simplecov (>= 0.22.0)
tty-which (~> 0.5.0)
virtus (~> 2.0)
securerandom (0.3.1)
securerandom (0.3.2)
sexp_processor (4.17.2)
simplecov (0.22.0)
docile (~> 1.1)
Expand Down Expand Up @@ -621,7 +629,9 @@ GEM
standard-performance (1.4.0)
lint_roller (~> 1.1)
rubocop-performance (~> 1.21.0)
stringio (3.1.1)
store_model (4.1.0)
activerecord (>= 7.0)
stringio (3.1.2)
syntax_tree (6.2.0)
prettier_print (>= 1.2.0)
terminal-table (3.0.2)
Expand All @@ -630,9 +640,9 @@ GEM
thor (1.3.2)
thread_safe (0.3.6)
tilt (2.4.0)
timeout (0.4.1)
timeout (0.4.2)
tty-which (0.5.0)
turbo-rails (2.0.10)
turbo-rails (2.0.11)
actionpack (>= 6.0.0)
railties (>= 6.0.0)
turbo_power (0.6.2)
Expand All @@ -641,10 +651,10 @@ GEM
concurrent-ruby (~> 1.0)
unaccent (0.4.0)
unicode-display_width (2.6.0)
uri (0.13.1)
uri (1.0.2)
useragent (0.16.10)
view_component (3.17.0)
activesupport (>= 5.2.0, < 8.0)
view_component (3.20.0)
activesupport (>= 5.2.0, < 8.1)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
virtus (2.0.0)
Expand All @@ -662,14 +672,14 @@ GEM
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.8.2)
webrick (1.9.0)
websocket-driver (0.7.6)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
xpath (3.2.0)
nokogiri (~> 1.8)
yard (0.9.37)
zeitwerk (2.6.18)
zeitwerk (2.7.1)

PLATFORMS
ruby
Expand All @@ -687,6 +697,7 @@ DEPENDENCIES
annotate
appraisal
avo!
avo-meta!
avo-money_field
avo-record_link_field
aws-sdk-s3
Expand Down Expand Up @@ -751,6 +762,7 @@ DEPENDENCIES
spring-commands-rspec
sprockets-rails
standard
store_model
test-prof
tzinfo-data
web-console (>= 3.3.0)
Expand Down
11 changes: 10 additions & 1 deletion db/factories.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

factory :project do
name { Faker::App.name }
status { ['closed', :rejected, :failed, 'loading', :running, :waiting].sample }
status { ["closed", :rejected, :failed, "loading", :running, :waiting].sample }
stage { ["Discovery", "Idea", "Done", "On hold", "Cancelled", "Drafting"].sample }
budget { Faker::Number.decimal(l_digits: 4) }
country { Faker::Address.country_code }
Expand Down Expand Up @@ -148,4 +148,13 @@
name { Faker::Company.name }
size { ["small", "medium", "large"].sample }
end

factory :meta_schema, class: "Avo::Meta::Schema" do
resource_name { "User" }
schema_entries {
[
Avo::Meta::SchemaEntry.new(name: "shoe_size", as: "number", default: "9")

Check failure on line 156 in db/factories.rb

View workflow job for this annotation

GitHub Actions / lint / runner / standardrb 

[rubocop] reported by reviewdog 🐶
[Corrected] Layout/FirstArrayElementIndentation: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

Raw Output:
db/factories.rb:156:11: C: [Corrected] Layout/FirstArrayElementIndentation: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
          Avo::Meta::SchemaEntry.new(name: "shoe_size", as: "number", default: "9")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
]
}
end
end
105 changes: 105 additions & 0 deletions lib/avo/mappings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
module Avo
module Mappings
ASSOCIATIONS_MAPPING ||= {

Check failure on line 3 in lib/avo/mappings.rb

View workflow job for this annotation

GitHub Actions / lint / runner / standardrb 

[rubocop] reported by reviewdog 🐶
[Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.

Raw Output:
lib/avo/mappings.rb:3:26: W: [Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.
    ASSOCIATIONS_MAPPING ||= {
                         ^^^
ActiveRecord::Reflection::BelongsToReflection => {
field: "belongs_to"
},
ActiveRecord::Reflection::HasOneReflection => {
field: "has_one"
},
ActiveRecord::Reflection::HasManyReflection => {
field: "has_many"
},
ActiveRecord::Reflection::HasAndBelongsToManyReflection => {
field: "has_and_belongs_to_many"
}
}.freeze

ATTACHMENTS_MAPPING ||= {

Check failure on line 18 in lib/avo/mappings.rb

View workflow job for this annotation

GitHub Actions / lint / runner / standardrb 

[rubocop] reported by reviewdog 🐶
[Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.

Raw Output:
lib/avo/mappings.rb:18:25: W: [Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.
    ATTACHMENTS_MAPPING ||= {
                        ^^^
ActiveRecord::Reflection::HasOneReflection => {
field: "file"
},
ActiveRecord::Reflection::HasManyReflection => {
field: "files"
}
}.freeze

FIELDS_MAPPING ||= {

Check failure on line 27 in lib/avo/mappings.rb

View workflow job for this annotation

GitHub Actions / lint / runner / standardrb 

[rubocop] reported by reviewdog 🐶
[Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.

Raw Output:
lib/avo/mappings.rb:27:20: W: [Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.
    FIELDS_MAPPING ||= {
                   ^^^
primary_key: {
field: "id"
},
string: {
field: "text"
},
text: {
field: "textarea"
},
integer: {
field: "number"
},
float: {
field: "number"
},
decimal: {
field: "number"
},
datetime: {
field: "date_time"
},
timestamp: {
field: "date_time"
},
time: {
field: "date_time"
},
date: {
field: "date"
},
binary: {
field: "number"
},
boolean: {
field: "boolean"
},
references: {
field: "belongs_to"
},
json: {
field: "code"
}
}.freeze

NAMES_MAPPING ||= {

Check failure on line 72 in lib/avo/mappings.rb

View workflow job for this annotation

GitHub Actions / lint / runner / standardrb 

[rubocop] reported by reviewdog 🐶
[Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.

Raw Output:
lib/avo/mappings.rb:72:19: W: [Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.
    NAMES_MAPPING ||= {
                  ^^^
id: {
field: "id"
},
description: {
field: "textarea"
},
gravatar: {
field: "gravatar"
},
email: {
field: "text"
},
password: {
field: "password"
},
password_confirmation: {
field: "password"
},
stage: {
field: "select"
},
budget: {
field: "currency"
},
money: {
field: "currency"
},
country: {
field: "country"
}
}.freeze
end
end
Loading
Loading