Implementation of getting the iommu pci devices address #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunfuwen
reviewed
Oct 19, 2017
virttest/libvirt_xml/nodedev_xml.py
Outdated
| @@ -140,8 +140,27 @@ class for capability whose type is pci. | |||
| # <numa node='0'/> | |||
| #</capability> | |||
|
|
|||
| # or the Example of iommu: | |||
| #<capability type="pci"> | |||
There was a problem hiding this comment.
follow the comment format(leave one white space between # and following words):# xx ,and the following have similar issues.
There was a problem hiding this comment.
@chunfuwen Updated
iccaszhulili
force-pushed
the
iommuGroup
branch
from
02c3291 to
a78dcac
Compare
kylazhang
reviewed
Oct 19, 2017
virttest/libvirt_xml/nodedev_xml.py
Outdated
| accessors.XMLElementList('iommuGroup_number', self, | ||
| parent_xpath='/iommuGroup', | ||
| marshal_from=self.marshal_from_address, | ||
| marshal_to=self.marshal_to_address) |
There was a problem hiding this comment.
The iommuGroup_number should be an attribute? And here should be the 'iommuGroup_addresses' ? So I think you need to add both of them?
There was a problem hiding this comment.
@kylazhang Updated, please have a check
Add the function of getting the pci devices addresses sharing the same iommuGroup. Signed-off-by: Lily Zhu <[email protected]>
iccaszhulili
force-pushed
the
iommuGroup
branch
from
a78dcac to
ae940bc
Compare
kylazhang
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the function of getting the pci devices addresses
sharing the same iommuGroup.
Signed-off-by: Lily Zhu [email protected]