Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

software_manager: align avocado-vt with changes in avocado #3328

Conversation

lkotek
Copy link
Contributor

@lkotek lkotek commented Jan 13, 2022

PR alignes avocado-vt with software_manager changes in avocado

See: avocado-framework/avocado#5225

id: 2040126

Signed-off-by: Lukas Kotek [email protected]

@yanan-fu
Copy link
Contributor

@lkotek Seems virttest/utils_package be missed.

@lkotek lkotek force-pushed the align-with-avocado-software_manager-changes branch from 63c6a5a to e0e53e2 Compare January 13, 2022 09:32
@lkotek
Copy link
Contributor Author

lkotek commented Jan 13, 2022

@lkotek Seems virttest/utils_package be missed.

@yanan-fu Got it, thanks for pointing it out. Fixed.

@yanan-fu
Copy link
Contributor

@ana Would you please help review ?
With the change of avocado-framework/avocado#5225, vt-bootstrap will fail as:

  File "/usr/local/lib/python3.6/site-packages/avocado_framework_plugin_vt-94.0-py3.6.egg/virttest/utils_package.py", line 147, in <module>
    class LocalPackageMgr(software_manager.SoftwareManager):
AttributeError: module 'avocado.utils.software_manager' has no attribute 'SoftwareManager'

Error running method "initialize" of plugin "vt-init": module 'avocado.utils.software_manager' has no attribute 'SoftwareManager'
Avocado crashed unexpectedly: module 'avocado.utils.software_manager' has no attribute 'SoftwareManager'

Thanks!

@yanan-fu
Copy link
Contributor

@luckyh Could you please help review ? Thanks!

@ana ana self-requested a review January 13, 2022 10:13
Copy link
Contributor

@ana ana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkotek LGTM, thanks. There are two cirrus tests failing, thought.

@lkotek lkotek force-pushed the align-with-avocado-software_manager-changes branch from e0e53e2 to 490bcda Compare January 13, 2022 11:19
Copy link
Contributor

@luckyh luckyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the minimum requirement of Avocado will be updated to 82.x LTS (791c4ee), we can just ignore the CI failures.

@luckyh
Copy link
Contributor

luckyh commented Jan 13, 2022

@kylazhang @chunfuwen @dzhengfy please help double confirm the fix, thanks!

@lkotek
Copy link
Contributor Author

lkotek commented Jan 13, 2022

Since the minimum requirement of Avocado will be updated to 82.x LTS (791c4ee), we can just ignore the CI failures.

@luckyh Ah, great. Good to know. I was thinking how to address it with Avocado 70. So should I modify .cirrus.yml in case of centos_8_1_task the same way as we already have it for fedora_34_task matrix?

@luckyh
Copy link
Contributor

luckyh commented Jan 14, 2022

@luckyh Ah, great. Good to know. I was thinking how to address it with Avocado 70. So should I modify .cirrus.yml in case of centos_8_1_task the same way as we already have it for fedora_34_task matrix?

@lkotek I think we can leave it for #3295 as there is a more completed fix, thanks.

@ana ana merged commit e0fd369 into avocado-framework:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants