filesystem.py: add boot order attribute for filesystem device #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meina Li <[email protected]>
This was referenced Oct 12, 2023
chloerh
reviewed
Oct 26, 2023
| @@ -29,6 +29,8 @@ def __init__(self, type_name='mount', virsh_instance=base.base.virsh): | |||
| accessors.XMLElementDict('alias', self, | |||
| parent_xpath='/', | |||
| tag_name='alias') | |||
| accessors.XMLAttribute('boot', self, parent_xpath='/', | |||
There was a problem hiding this comment.
We could consider XMLElementDict if there are new attributes to 'boot' element in the future.
And we could keep the current implement if the chance of adding new attribute is really small.
There was a problem hiding this comment.
I think we can keep it in current status because it is unlikely that there will be a new attribute to 'boot' element. If there are indeed changes later, we can update them together.
chloerh
approved these changes
Nov 3, 2023
| @@ -29,6 +29,8 @@ def __init__(self, type_name='mount', virsh_instance=base.base.virsh): | |||
| accessors.XMLElementDict('alias', self, | |||
| parent_xpath='/', | |||
| tag_name='alias') | |||
| accessors.XMLAttribute('boot', self, parent_xpath='/', | |||
yiqianwei
pushed a commit
to yiqianwei/avocado-vt
that referenced
this pull request
Nov 6, 2023
filesystem.py: add boot order attribute for filesystem device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add boot order attribute for filesystem device.