qemu_vm: includes support for mem policy and host-nodes #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After applying the avocado-vt patch Now the machine memory includes the policy and host-nodes option |
|
@yanan-fu could you review this PR? Thanks ! |
|
This patch aim to add new options for the machine mem object, so it can bind the machine mem to the specified host numa node. |
YongxueHong
reviewed
Nov 13, 2023
virttest/qemu_vm.py
Outdated
| if params.get("vm_mem_policy"): | ||
| backend_options["policy_mem"] = params.get("vm_mem_policy") | ||
| if params.get("vm_mem_host-nodes"): | ||
| backend_options["host-nodes"] = params.get("vm_mem_host-nodes") |
There was a problem hiding this comment.
Suggested change
| backend_options["host-nodes"] = params.get("vm_mem_host-nodes") | |
| backend_options["host-nodes"] = params.get("vm_mem_host_nodes") |
To align with the current design of the format parameters, I suggest using the underline to split the different keywords.
Thanks.
There was a problem hiding this comment.
@YongxueHong I understand line 1102 needs to be vm_mem_host_nodes as well
There was a problem hiding this comment.
Could you review again this PR? Thanks!
Includes the support of the policy and host-nodes options for the machine memory backend. Signed-off-by: mcasquer <[email protected]>
mcasquer
force-pushed
the
1398_machine_mem_support
branch
from
8421dd7 to
5c428c2
Compare
|
It seems this PR could be merged 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qemu_vm: includes support for mem policy and host-nodes
Includes the support of the policy and host-nodes options
for the machine memory backend.
ID: 1398
Signed-off-by: mcasquer [email protected]