libvirt_numa: Fix parsing of continuous numa nodes #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzhengfy Could you please take a look? |
dzhengfy
reviewed
Jan 28, 2024
| If node list is [0, 2, 3, 5], return 1 | ||
| If node list is [1, 4, 8], return -1 | ||
| If node list is [0, 1, 2, 3], return "0-3" | ||
| If node list is [0, 2, 3, 4], return "-1" |
There was a problem hiding this comment.
I feel we should return "2-4" if node list is [0, 2, 3, 4]
hs0210
force-pushed
the
parse_numa_nodeset_to_str
branch
2 times, most recently
from
fca8cb2 to
c0a225c
Compare
|
@dzhengfy I have written a new func to convert all online numa nodes to a string, PTAL. The CI failure should be anther issue. |
dzhengfy
reviewed
Mar 1, 2024
| node_ranges.append(f"{start_node}-{end_node}") | ||
|
|
||
| converted_numa_nodes = ",".join(node_ranges) | ||
| LOG.debug("Convert output for all online numa nodes: '%s'" % converted_numa_nodes) |
|
Others LGTM |
hs0210
force-pushed
the
parse_numa_nodeset_to_str
branch
from
c0a225c to
ce4caa6
Compare
In some cases, we need a string representation of all online numa nodes. Signed-off-by: Hu Shuai <[email protected]>
dzhengfy
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of continuous numa nodes.
Parsing result without the patch:
Testing result without the patch:
Parsing result with the patch:
Testing result with the patch: