env_process: Refactor kvm module reload/restore steps #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KVM modules are reloaded and restored before and after running tests.
That was done directly in the preprocess and postprocess functions in
virttest.env_process. Write a Setuper subclass that implements those in
setup/cleanup methods and register the setuper in the env_process
setup_manager.
This is a patch from a larger patch series refactoring the env_process
preprocess and postprocess functions. In each of these patches, a
pre/post process step is identified and replaced with a Setuper subclass
so the following can finally be met:
- Only cleanup steps of successful setup steps are run to avoid
possible environment corruption or hard to read errors.
- Running setup/cleanup steps symmetrically during env pre/post
process.
- Reduce explicit pre/post process function code length.
Signed-off-by: Beñat Gartzia Arruabarrena <[email protected]>
bgartzi
force-pushed
the
env_process_refactoring-reload_kvm
branch
from
a0463ce to
6d21daa
Compare
|
A test failed at first [0]. After checking it, I thought it could have been a cirrus issue, I'm not sure though. A flaky test perhaps? Anyway, after pushing the patch again all the checks were able to pass. @YongxueHong would you mind having a look? Thanks! |
smitterl
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KVM modules are reloaded and restored before and after running tests. That was done directly in the preprocess and postprocess functions in virttest.env_process. Write a Setuper subclass that implements those in setup/cleanup methods and register the setuper in the env_process setup_manager.
This is a patch from a larger patch series refactoring the env_process preprocess and postprocess functions. In each of these patches, a pre/post process step is identified and replaced with a Setuper subclass so the following can finally be met:
- Only cleanup steps of successful setup steps are run to avoid possible environment corruption or hard to read errors.
- Running setup/cleanup steps symmetrically during env pre/post process.
- Reduce explicit pre/post process function code length.
ID: 2934