Use raw image format by default for block devices #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pevogam
force-pushed
the
default-image-format
branch
from
69c6dfc to
d4f00fb
Compare
|
@luckyh @YongxueHong I hope this is an improvement, it definitely helped us. |
YongxueHong
reviewed
Dec 30, 2024
Not providing a default behavior leads to use of variable without a value and thus cryptic errors regarding the simple fact that we have to provide an image format. It is also not recommended in any conditionals as it leads to undefined behaviors. Finally, in the case of multiple images we may have "image_format=" to use empty string which should be handled similarly to None (lack of any image_format parameter) or generally as the comment suggests to a meaningful default behavior. Signed-off-by: Plamen Dimitrov <[email protected]>
pevogam
force-pushed
the
default-image-format
branch
from
d4f00fb to
45a1e2b
Compare
YongxueHong
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not providing a default behavior leads to use of variable without a value and thus cryptic errors regarding the simple fact that we have to provide an image format. It is also not recommended in any conditionals as it leads to undefined behaviors. Finally, in the case of multiple images we may have "image_format=" to use empty string which should be handled similarly to None (lack of any image_format parameter) or generally as the comment suggests to a meaningful default behavior.