Add module virtadmin #766
Merged
Add module virtadmin #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccaszhulili
force-pushed
the
virt-admin
branch
from
54afca4 to
4382ab0
Compare
This was referenced Dec 10, 2016
iccaszhulili
force-pushed
the
virt-admin
branch
from
4382ab0 to
96cf175
Compare
will-Do
reviewed
Dec 19, 2016
|
|
||
| if readonly: | ||
| logging.error("readonly mode is not supported by virt-admin yet.") | ||
| self.virtadmin_exec += " -r" |
There was a problem hiding this comment.
Does virt-admin support 'readonly' feature?
| # logging.debug("Persistent virtadmin session is not responding, " | ||
| # "libvirtd may be dead.") | ||
| # self.auto_close = True | ||
| # raise aexpect.ShellStatusError(virtadmin_exec, 'list') |
There was a problem hiding this comment.
You can remove these codes If they are usless
| return 0, out | ||
|
|
||
| def cmd_result(self, cmd, ignore_status=False, debug=False, timeout=60): | ||
| """Mimic process.run()""" |
There was a problem hiding this comment.
Better to complete this docsting
iccaszhulili
force-pushed
the
virt-admin
branch
from
96cf175 to
3237c91
Compare
|
@will-Do I have modified the file according to your comments. Please help me review it. Thanks very much. |
iccaszhulili
force-pushed
the
virt-admin
branch
from
3237c91 to
06b959b
Compare
In order to automate the test case of the new feature virt-admin, I have added module virt_admin. And also add all commands related to virt-admin into this virt_admin.py. Signed-off-by: Lily Zhu <[email protected]>
iccaszhulili
force-pushed
the
virt-admin
branch
from
06b959b to
cdd1335
Compare
will-Do
approved these changes
Jan 4, 2017
|
As no more concern about this new module, and it only used for virt-admin related cases for now, I'm going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to automate the test case of the new feature virt-admin, I have
added module virtadmin.