drop support to the legacy runner #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtja
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Hi @beraldoleal thanks for this. I am glad that the legacy runner is being removed. Shouldn't we add a reference to the #5138 here?
beraldoleal
force-pushed
the
issues/legacy-runner
branch
4 times, most recently
from
efaceb1 to
7b14846
Compare
|
Thanks @richtja fixed. |
richtja
reviewed
Dec 10, 2021
beraldoleal
force-pushed
the
issues/legacy-runner
branch
from
7b14846 to
2c5f3e5
Compare
richtja
requested changes
Dec 10, 2021
beraldoleal
force-pushed
the
issues/legacy-runner
branch
2 times, most recently
from
c510e19 to
c03dbba
Compare
clebergnu
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Please don't merge this yet, because we need a resolution on avocado-framework/avocado-vt#3295, or else Avocado-VT CI will be broken after this.
clebergnu
reviewed
Dec 13, 2021
beraldoleal
force-pushed
the
issues/legacy-runner
branch
2 times, most recently
from
5bbffc0 to
3d5e859
Compare
Signed-off-by: Beraldo Leal <[email protected]>
This is the default option at this point. We are not using it at all. In fact there was a typo error there. Signed-off-by: Beraldo Leal <[email protected]>
Dropping support to the legacy runner. Signed-off-by: Beraldo Leal <[email protected]>
r.i.p legacy runner. Related to avocado-framework#5138. Signed-off-by: Beraldo Leal <[email protected]>
beraldoleal
force-pushed
the
issues/legacy-runner
branch
from
3d5e859 to
11567e2
Compare
|
@clebergnu since 3295 on avocado-vt it is closed, is there any missing bit for this get merged? |
|
@clebergnu can we merge this now? since avocado-framework/avocado-vt#3295 got merged? |
ana
reviewed
Jan 25, 2022
| @@ -208,8 +208,7 @@ def register_core_options(): | |||
| '"avocado plugins" and find the list of valid runners ' | |||
| 'under the "Plugins that run test suites on a job ' | |||
| '(runners) section. Defaults to "nrunner", which is ' | |||
| 'the new runner. To use the conventional and traditional ' | |||
| 'runner, use "runner".') | |||
| 'the new runner and only runner supported at this moment.') | |||
There was a problem hiding this comment.
nitpick: I'd drop here the new runner reference, it'll get old quite fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy runner is not maintained any more and deprecated. Users are encouraged to use the new runner or the latest avocado release in case still need this.
r.i.p legacy runner.