Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong tmp_path alloc size, not uniq temp file #11

Merged
merged 1 commit into from
Jan 10, 2015

Conversation

plepers
Copy link
Contributor

@plepers plepers commented Jan 10, 2015

Hi,

It's a small fix for non windows platforms.
The creation of temp file (awdutil_mktmp) is broken on OSX. tmp_path isn't null terminated, then mkstemp don't work properly.

Pierre

@80prozent
Copy link
Member

Hey Pierre

Thanks for contributing to the project. All help is highly appreciated.

The thing is, that i am working on a complete make-over for the awd-sdk.

I am making good progress, and i think i will be able to share the new version quite soon.

This make-over / refactor hardly leaves any line of code untouched. For examples, most string-operations will be handled with std::string now.

For more information about the changes i am doing, please have a look at this issue

Any comments on this issue are highly appreciated.

Thanks

Robin

PS: i will merge your pull requests, but they will be overwritten once i commit the refactored library.

80prozent added a commit that referenced this pull request Jan 10, 2015
wrong tmp_path alloc size, not uniq temp file
@80prozent 80prozent merged commit b273642 into awaytools:master Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants