Feature/ud field types #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manhhnee
force-pushed
the
feature/UD_Field_Types
branch
3 times, most recently
from
0866d90 to
329fc95
Compare
|
ready |
vanvtt-0952
reviewed
Mar 21, 2024
manhhnee
force-pushed
the
feature/UD_Field_Types
branch
from
329fc95 to
dfd0e1d
Compare
manhhnee
force-pushed
the
feature/UD_Field_Types
branch
from
dfd0e1d to
0472fd5
Compare
|
ready |
binhpt-1239
reviewed
Mar 21, 2024
|
|
||
| def update | ||
| if @field_type.update(field_type_params) | ||
| update_prices(params) |
There was a problem hiding this comment.
Đặt xử lý này vào callback của model nha. Để khi update field_type thì chạy luôn
Comment on lines
+30
to
+31
| admin: | ||
| introduce: "This is the admin page" |
There was a problem hiding this comment.
Thêm i18n ở file vi nữa
| field_type: | ||
| create_success: "Tạo loại sân thành công" | ||
| create_fail: "Tạo loại sân thất bại" | ||
| not_found: "Không tìm thấy đơn đặt này" |
There was a problem hiding this comment.
Không thấy thay đổi ở file en nhỉ
Comment on lines
+64
to
+72
| booking: | ||
| delete_success: "Lịch đặt sân đã bị xóa" | ||
| delete_fail: "Đặt sân thành công" | ||
| field: | ||
| create: "Tạo mới" | ||
| add_field: "Thêm sân bóng" | ||
| close: "Đóng" | ||
| field: | ||
| create: "Tạo mới" |
There was a problem hiding this comment.
Check luôn i18n chỗ này
| @@ -37,8 +60,16 @@ def load_field | |||
| redirect_to admin_fields_path | |||
| end | |||
|
|
|||
| def load_field_type | |||
| @field_type = FieldType.find_by(id: params[:id]) | |||
There was a problem hiding this comment.
Có cần load field_type từ field không. Và check thêm điều kiện user có phải chủ sân không nữa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Tickets
WHAT (optional)
HOW
WHY (optional)
Evidence (Screenshot or Video)