Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): Add ability to use OkHttp4 with Amplify v2.x #2970

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2809

Description of changes:
All AWS clients will now use the Http4Engine if it is available on the classpath.

How did you test these changes?

  • Create test app using OkHttp4 and verify the correct engine is used in Amplify

Documentation update required?

  • No
  • Yes: Docs update TODO

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach
Copy link
Member

I checked for all extensions of SdkClient and verified that no use cases were missed.

Can you confirm that our own usages of OkHttp don't use any OkHttp v5 only methods. Examples of these are the OkHttp clients that we create within Amplify API and our Liveness Rekognition WebSocket.

Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Liveness Sample app using both API and Liveness OkHttp v4 and all worked as expected.

@mattcreaser mattcreaser enabled auto-merge (squash) January 15, 2025 19:45
@mattcreaser mattcreaser merged commit fe0c468 into main Jan 15, 2025
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/okhttp4 branch January 15, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants