handle usage of subnamespaced types in api check (#1952)

aws-amplify · Sep 3, 2024 · 0135b3c · 0135b3c
1 parent 6ee7d08
commit 0135b3c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/...dator/test-resources/test-projects/without-breaks/project-with-namespace/API.md b/...dator/test-resources/test-projects/without-breaks/project-with-namespace/API.md
@@ -12,9 +12,14 @@ type SomeTypeUnderSubNamespace = {
   someOtherProperty: string;
 }
 
+type SomeOtherTypeUnderSubNamespace = {
+  someProperty: SomeTypeUnderSubNamespace;
+};
+
 declare namespace someSubNamespace {
   export {
-    SomeTypeUnderSubNamespace
+    SomeTypeUnderSubNamespace,
+    SomeOtherTypeUnderSubNamespace
   }
 }
 

diff --git a/...t-resources/test-projects/without-breaks/project-with-namespace/src/some_sub_namespace.ts b/...t-resources/test-projects/without-breaks/project-with-namespace/src/some_sub_namespace.ts
@@ -1,3 +1,7 @@
 export type SomeTypeUnderSubNamespace = {
   someOtherProperty: string;
 };
+
+export type SomeOtherTypeUnderSubNamespace = {
+  someProperty: SomeTypeUnderSubNamespace;
+};
diff --git a/scripts/components/api-changes-validator/usage_statemets_renderer.ts b/scripts/components/api-changes-validator/usage_statemets_renderer.ts
@@ -69,7 +69,7 @@ export class UsageStatementsRenderer {
 
       // characters that can be found before or after symbol
       // this is to prevent partial matches in case one symbol's characters are subset of longer one
-      const symbolTerminators = '[\\s\\,\\(\\)<>]';
+      const symbolTerminators = '[\\s\\,\\(\\)<>;]';
       const regex = new RegExp(
         `(${symbolTerminators})(${symbolName})(${symbolTerminators})`,
         'g'