Skip to content

Commit

Permalink
Revert "chore: moved execa comment to check_dependencies.ts"
Browse files Browse the repository at this point in the history
This reverts commit 44a9051.
  • Loading branch information
Vieltojarvi committed Aug 29, 2024
1 parent 44a9051 commit 5d5439e
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions scripts/check_dependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ await new DependenciesValidator(
[['aws-cdk', 'aws-cdk-lib']],
[
{
// @aws-amplify/plugin-types can depend on execa@^5.1.1 as a workaround for https://github.com/aws-amplify/amplify-backend/issues/962
// all other packages must depend on execa@^8.0.1
// this can be removed once execa is patched
dependencyName: 'execa',
globalDependencyVersion: '^8.0.1',
exceptions: [
Expand Down
3 changes: 3 additions & 0 deletions scripts/components/dependencies_validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@ export class DependenciesValidator {
(x) => x.dependencyName === packageName
);
if (inconsistentDependency) {
// @aws-amplify/plugin-types can depend on execa@^5.1.1 as a workaround for https://github.com/aws-amplify/amplify-backend/issues/962
// all other packages must depend on execa@^8.0.1
// this can be removed once execa is patched
return (declarations) => {
const validationResult = declarations.every(
({ dependentPackageName, version }) =>
Expand Down

0 comments on commit 5d5439e

Please sign in to comment.