Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that name passed to AmplifyError has desired suffix #1885

Closed
sobolk opened this issue Aug 20, 2024 · 2 comments
Closed

Enforce that name passed to AmplifyError has desired suffix #1885

sobolk opened this issue Aug 20, 2024 · 2 comments
Assignees
@sobolk
Labels
repo-infrastructure Engineering label for issues related to repo infrastructure tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later

Comments

@sobolk
Copy link
Member

sobolk commented Aug 20, 2024

From #1883 (comment) .

If AmplifyUserError or AmplifyError is created we should suffix name with Error or Fault. Failure to do so might cause wrong classification.
This should be enforceable by custom linter rule.
@sobolk sobolk added tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later repo-infrastructure Engineering label for issues related to repo infrastructure labels Aug 20, 2024
@sobolk sobolk mentioned this issue Aug 20, 2024
Merged
4 tasks
@sobolk sobolk self-assigned this Aug 20, 2024
@sobolk sobolk mentioned this issue Aug 20, 2024
Merged
4 tasks
@sobolk
Copy link
Member Author

sobolk commented Aug 20, 2024

#1889

@sobolk
Copy link
Member Author

sobolk commented Aug 20, 2024

Done!

@sobolk sobolk closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolk sobolk

Labels
repo-infrastructure Engineering label for issues related to repo infrastructure tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolk