Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error names in storage and functions. #1883

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Aug 19, 2024

Problem

Two error names are missing Error suffix and are classified as unknown faults.

Issue number, if available:

Changes

Add Error suffix.

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner August 19, 2024 23:34
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 8e2d1e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend-function Patch
@aws-amplify/backend-storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rtpascual
Copy link
Contributor

Maybe we can create an issue to enforce error names to have the suffix Error?

@sobolk
Copy link
Member Author

sobolk commented Aug 20, 2024

Maybe we can create an issue to enforce error names to have the suffix Error?

#1885

@sobolk sobolk merged commit 775e2bb into main Aug 20, 2024
37 checks passed
@sobolk sobolk deleted the fix-missing-error-suffixes branch August 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants