Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @parcel/watcher to use the latest version #1113

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented Mar 7, 2024

Problem

@parcel/watcher was downgraded in #1045 because it breaks [email protected]. see parcel-bundler/watcher#156.

Now according to parcel-bundler/watcher#156 (comment), the issue is resolved since @parcel/[email protected], so we can upgrade it to the latest version.

Issue number, if available:

fixes #1039

Changes

  • upgrade @parcel/watcher to the latest version

Corresponding docs PR, if applicable:

Validation

Manually verified. Will add a e2e test for nextjs #1038

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 2eb1f30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/sandbox Patch
@aws-amplify/backend-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0618 0618 added the run-e2e Label that will include e2e tests in PR checks workflow label Mar 7, 2024
Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test, or have we done a manual test to confirm the issue is gone?

@0618
Copy link
Contributor Author

0618 commented Mar 7, 2024

Do we have a test, or have we done a manual test to confirm the issue is gone?

Manually verified. It works. I'll add a e2e test for nextjs in a follow-up PR for #1038

@0618 0618 merged commit 615a3e6 into main Mar 7, 2024
24 checks passed
@0618 0618 deleted the upgrade-pacel-watcher branch March 7, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade @parcel/watcher to latest
3 participants