-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor top level cli error handling #1730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amplifiyer
added
the
run-e2e
Label that will include e2e tests in PR checks workflow
label
Jul 10, 2024
🦋 Changeset detectedLatest commit: 8cc4cb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edwardfoyle
reviewed
Jul 10, 2024
0618
reviewed
Jul 11, 2024
0618
previously approved these changes
Jul 11, 2024
edwardfoyle
previously approved these changes
Jul 11, 2024
awsluja
previously approved these changes
Jul 11, 2024
awsluja
approved these changes
Jul 11, 2024
edwardfoyle
approved these changes
Jul 12, 2024
fangyuwu7
pushed a commit
to fangyuwu7/amplify-backend
that referenced
this pull request
Jul 15, 2024
* refactor top level cli error handling * PR updates * Add cause * update api after clean build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue number, if available:
Changes
try/catch
to perform error handling.FromError
method to also check forCredentialsError
which can happen at any aws-sdk call site and wrap it inAmplifyUserError
AccountIdFetcher
to not fail when user doesn't have credentials, rather just return a dummy value for metrics.AccountIdFetcher
for subsequent sandbox deployment runs.Corresponding docs PR, if applicable:
Validation
Unit tests.
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.