Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a case where domain is not included in outputs if name property is specified #1746

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Jul 15, 2024

Problem

Domain is not included in outputs when name is specified.

Issue number, if available:
#1724

Changes

Include name in domain output generation logic.

Corresponding docs PR, if applicable:

Validation

Unit test added.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner July 15, 2024 18:17
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: b84287f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/auth-construct Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk enabled auto-merge (squash) July 15, 2024 18:23
@sobolk sobolk merged commit 157175a into main Jul 15, 2024
36 checks passed
@sobolk sobolk deleted the fix-domain-if-name branch July 15, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants