Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configuring SES for email sender #1851

Merged
merged 15 commits into from
Aug 19, 2024

Conversation

ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Aug 12, 2024

Problem

Issue number, if available: N/A

Changes

  • exposed parameters to configure Cognito to send emails with SES
  • updated auth-construct to be able to feed new properties (related to configuring SES) to User Pool settings
  • added corresponding test to validate SES email configuration is set up if user provides data for it

Corresponding docs PR, if applicable:

Validation

  • added unit test to verify email configuration happens when subfields within senders (fromEmail, fromName, and replyTo) are populated
  • manually deployed test project with SES email configuration included (record of successful deployment below)
    successful_deployment_with_SES

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 073e20e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/auth-construct Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ShadowCat567 ShadowCat567 marked this pull request as ready for review August 16, 2024 17:03
@ShadowCat567 ShadowCat567 requested review from a team as code owners August 16, 2024 17:03
sobolk
sobolk previously approved these changes Aug 16, 2024
rtpascual
rtpascual previously approved these changes Aug 16, 2024
awsluja
awsluja previously approved these changes Aug 16, 2024
@ShadowCat567 ShadowCat567 dismissed stale reviews from awsluja, rtpascual, and sobolk via 794ba4b August 16, 2024 23:09
@ShadowCat567 ShadowCat567 merged commit 61d4fb3 into aws-amplify:main Aug 19, 2024
37 checks passed
@ShadowCat567 ShadowCat567 deleted the SES-email-sender branch August 19, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants