Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat: Multi bucket support"" #1856

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented Aug 13, 2024

Reverts #1837

Re-do #1742 since 1) it passed the partner teams' test and 2) we completed the sev2 release yesterday.

@0618 0618 requested review from a team as code owners August 13, 2024 14:21
Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: ee818bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@aws-amplify/deployed-backend-client Minor
@aws-amplify/backend-output-schemas Minor
@aws-amplify/backend-output-storage Minor
@aws-amplify/backend-storage Minor
@aws-amplify/client-config Minor
@aws-amplify/plugin-types Minor
@aws-amplify/backend Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0618 0618 added the run-e2e Label that will include e2e tests in PR checks workflow label Aug 13, 2024
sobolk
sobolk previously approved these changes Aug 13, 2024
rtpascual
rtpascual previously approved these changes Aug 13, 2024
@josefaidt
Copy link
Contributor

can we bump this version constant to 1.1?
https://github.com/aws-amplify/amplify-backend/blob/revert-1837-revert-1742-multi-bucket-support/packages/client-config/src/client-config-schema/schema_v1.1.json#L15

@0618 0618 dismissed stale reviews from rtpascual and sobolk via 4990f7b August 15, 2024 15:42
@0618
Copy link
Contributor Author

0618 commented Aug 15, 2024

sobolk
sobolk previously approved these changes Aug 15, 2024
rtpascual
rtpascual previously approved these changes Aug 15, 2024
@0618 0618 merged commit d9b83a1 into main Aug 15, 2024
59 of 61 checks passed
@0618 0618 deleted the revert-1837-revert-1742-multi-bucket-support branch August 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants