Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap SyntaxErrors in AmplifyUserError #1873

Merged
merged 1 commit into from
Aug 15, 2024
Merged

wrap SyntaxErrors in AmplifyUserError #1873

merged 1 commit into from
Aug 15, 2024

Conversation

rtpascual
Copy link
Contributor

Problem

SyntaxErrors that we throw during ampx sandbox here and here are being sent to our telemetry as UnknownFaults.

Issue number, if available:

Changes

Make sure we wrap SyntaxErrors in AmplifyUserError.

Corresponding docs PR, if applicable:

Validation

Unit tests.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rtpascual rtpascual requested review from a team as code owners August 15, 2024 23:10
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 234da2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/platform-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rtpascual rtpascual merged commit 4cce19f into main Aug 15, 2024
36 of 37 checks passed
@rtpascual rtpascual deleted the syntax-error branch August 15, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants