Select random region in health check #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sobolk
changed the title
sobolk
commented
Aug 23, 2024
Comment on lines
+51
to
+57
| if [ -z "${{ inputs.aws_region }}" ]; then | ||
| regions=("us-west-2" "us-east-1" "ca-central-1" "eu-central-1") | ||
| rand=$[$RANDOM % ${#regions[@]}] | ||
| selected_aws_region=${regions[$rand]} | ||
| else | ||
| selected_aws_region="${{ inputs.aws_region }}" | ||
| fi |
There was a problem hiding this comment.
I chose bash for this, because it doesn't involve any JSON parsing like we do in case of account selection.
And is rather simple at this point.
rtpascual
approved these changes
Aug 23, 2024
awsluja
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We could spread health_checks traffic across regions we also use for canaries (since they're bootstrapped anyway).
This is a follow up on this #1902 (comment) .
Changes
Validation
I looked at jobs to see if canaries keep their stickyness and if health checks select random regions.
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.